Does my visa application need to be approved before applying for the NIF?

No, you can apply for a NIF at any time. As we understand, some consulates require applicants to have a NIF and Portuguese bank account set up before submitting their visa application. You should check with the Portugal consulate that you will be applying through to get confirmation on their requirements.